Fix a bug in Decodable support #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the GRDB support for
Decodabletypes.The
decodeNil(forKey:)method of the keyed container that feeds from a database row could wrongly return false, and prevent an app from successfully decoding a nil optional value from a NULL column. This is fixed.This PR also introduces a partial support for
nestedContainer(keyedBy:forKey:). This method used to crash with a "not implemented" fatal error. Now it can decode nested scopes added by aScopeAdapteror requests that include a to-one association such asBelongsToorHasOne. It is still impossible to trigger JSON decoding of a column by using this method.Fixes #1531.