Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatter: remove multiple duplicated, add additional spaces in some cases #1037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mojo2012
Copy link

@mojo2012 mojo2012 commented Feb 20, 2020

So I created another PR for my formatter changes.

#941

@eric-milles
Copy link
Member

eric-milles commented Feb 20, 2020

A couple notes to start with:

  1. When you edit a source in org.codehaus.groovyXX, you will likely need to make changes to the same source in the other groovy version bundles.
  2. Have you run these changes on a larger codebase to see if they cause any problems for less common source constructs? The tests are often very simple and I'm not sure of the overall coverage of the formatter tests specifically.
  3. Are any of these formatter settings configurable? The original issue mentions the Java formatter settings. If possible, it would be best to support the same preferences so you can get a similar result for Java and Groovy files.
  4. Is it possible to divide these changes into some smaller groups so we can review and merge in smaller increments?

@eric-milles eric-milles force-pushed the master branch 4 times, most recently from 95284b0 to c7dc75b Compare April 9, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants