Temporarily freeze react version, upgrade other dependencies #7227
Conversation
| @@ -464,8 +464,8 @@ exports[`Anchor matches icon size to size prop when theme.icon.matchSize is true | |||
| -webkit-flex: 0 0 auto; | |||
| -ms-flex: 0 0 auto; | |||
| flex: 0 0 auto; | |||
| width: NaNpx; | |||
| height: NaNpx; | |||
| width: NaNxsmall; | |||
There was a problem hiding this comment.
do we want these? I remember they are from grommet-icons wasn't sure if we looked into why they changed
There was a problem hiding this comment.
I'm guessing it is coming from this PR, but not positive: https://github.com/grommet/grommet-icons/pull/325/files
Either way I think visually this test wouldn't change. The width is just being replaced with another invalid option.
At some point we should look at the useSizedIcon function in Grommet, I think this is where the issue may be coming from. I think the icons are supposed to scale to the size of the Anchor. This isn't working currently and this PR doesn't change that it just changes the incorrect value to another incorrect value.
There was a problem hiding this comment.
Do we have a ticket somewhere to capture?
There was a problem hiding this comment.
It doesn't look like it, I'll go ahead and make an issue
There was a problem hiding this comment.
Issue created: #7231
What does this PR do?
Temporarily freeze react version at v18.2.0 until we have a chance to do that upgrade (tracked here: #7127).
This PR upgrades some other dependencies
Where should the reviewer start?
What testing has been done on this PR?
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
no
Is this change backwards compatible or is it a breaking change?
backwards compatible