Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not upgrade certain dependencies #7127

Open
britt6612 opened this issue Feb 9, 2024 · 2 comments
Open

Can not upgrade certain dependencies #7127

britt6612 opened this issue Feb 9, 2024 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@britt6612
Copy link
Collaborator

britt6612 commented Feb 9, 2024

Currently we are unable to upgrade the following dependencies at this time.

    "@testing-library/dom": "9.3.0",
    "babel-plugin-styled-components": "2.0.6",
    "del": "^6.1.1",
    "jest-styled-components": "7.0.5",
    "styled-components": "5.3.9",
    "testcafe": "3.3.0",
  • "@testing-library/dom": "9.3.0",
 Uncaught [Error: Uncaught 'Warning: An update to %s inside a test was not wrapped in act(...).\n' 
  • "babel-plugin-styled-components": "2.0.6",

    • Test suite failed to run
  • "testcafe": "3.3.0",

Screen Shot 2024-02-07 at 6 38 32 PM
  • "jest-styled-components": "7.0.5",
    This was getting rid of classnames in the snap shots
Screen Shot 2024-02-07 at 6 44 20 PM
  • "styled-components": "6.1.8",

    thrown: "Warning: React does not recognize the %s prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase %s instead. If you accidentally passed it from a parent component, remove it from the DOM element.%s"

@britt6612 britt6612 added the dependencies Pull requests that update a dependency file label Feb 9, 2024
@britt6612
Copy link
Collaborator Author

Adding to the dependencies that we can not update at this time

    "react-dom": "^18.2.0",
    "react-is": "^18.2.0",

thrown: "Warning: ReactDOMTestUtils.act is deprecated in favor of React.act. Import act from react instead of react-dom/test-utils. See https://react.dev/warnings/react-dom-test-utils for more info."

We will need to go over 200+ tests if we want to update we will need to update our tests to use act and import from React.
Warning: An update to %s inside a test was not wrapped in act(...).\n

https://react.dev/warnings/react-dom-test-utils

https://github.com/facebook/react/releases

@jcfilben
Copy link
Collaborator

Adding to the dependencies that we can not update at this time

    "react-dom": "^18.2.0",
    "react-is": "^18.2.0",

thrown: "Warning: ReactDOMTestUtils.act is deprecated in favor of React.act. Import act from react instead of react-dom/test-utils. See https://react.dev/warnings/react-dom-test-utils for more info."

We will need to go over 200+ tests if we want to update we will need to update our tests to use act and import from React. Warning: An update to %s inside a test was not wrapped in act(...).\n

https://react.dev/warnings/react-dom-test-utils

https://github.com/facebook/react/releases

We should remove the ^ so that we temporarily freeze the versions at 18.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants