Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectMultiple - Loading enhancement #6351

Open
jcfilben opened this issue Sep 23, 2022 · 5 comments · May be fixed by #6491
Open

SelectMultiple - Loading enhancement #6351

jcfilben opened this issue Sep 23, 2022 · 5 comments · May be fixed by #6491
Labels
enhancement A suggestion to add to or change behavior
Projects
Grommet/Design System Backlog

Comments

@jcfilben
Copy link
Collaborator

jcfilben commented Sep 23, 2022 •
edited

Enhance SelectMultiple to allow for loading text or spinner to display if data is taking some time to fetch. We can use the help prop to pass in the loading text, we just need to be able to set options to undefined or null until the options get loaded in. Currently we get an error if options is null or undefined.

Screen Shot 2022-09-23 at 2 22 19 PM
@jcfilben jcfilben added the enhancement A suggestion to add to or change behavior label Sep 23, 2022
@jcfilben jcfilben added this to Triage in Grommet/Design System Backlog via automation Sep 23, 2022
@ericsoderberghp ericsoderberghp moved this from Triage to Next Active in Grommet/Design System Backlog Sep 26, 2022
@ericsoderberghp ericsoderberghp moved this from Next Active to To do in Grommet/Design System Backlog Sep 26, 2022
@BrunoViveiros
Copy link
Contributor

Can I take this one ?

@britt6612
Copy link
Collaborator

@BrunoViveiros of course feel free to reach out if you need anything!

@jcfilben
Copy link
Collaborator Author

jcfilben commented Nov 2, 2022

Hey @BrunoViveiros I just wanted to check in on this issue and see if you are still interested in working on it or if you had any questions

@BrunoViveiros
Copy link
Contributor

@jcfilben sorry for the delay, I'll try to finish it this week, any doubts I have related to the problem I'll put it here in the issue

@jcfilben
Copy link
Collaborator Author

jcfilben commented Nov 2, 2022

No worries! Feel free to reach out if you need anything

@BrunoViveiros BrunoViveiros linked a pull request Nov 14, 2022 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A suggestion to add to or change behavior
Projects
Grommet/Design System Backlog
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: makes SelectMultiple accept undefined or null BrunoViveiros/grommet
3 participants
@BrunoViveiros @britt6612 @jcfilben