Update Card docs #324
Open
Update Card docs #324
+252
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,13 +93,6 @@ export default () => ( | |||
| <Example>"small"</Example> | |||
| </PropertyValue> | |||
| </Property> | |||
|
|
|||
| <Property name="card.hover.container.extend"> | |||
There was a problem hiding this comment.
Isn't this still possible, via
kind={{
hover: theme.card.hover?.container,
...theme.card.container,
}}
There was a problem hiding this comment.
The extend does not apply at the moment.
jcfilben
reviewed
Apr 15, 2022
|
base.d.ts has been updated to include It looks like yarn.lock just needs updated and then we can merge this |
|
Looks like there is still a merge conflict with yarn.lock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts card docs based on updates made in grommet/grommet#5762