Ensure manifest urls don't redirect #118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boisterous-sunburst-a5c941 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the current URLs don't have a trailing slash, they get instantly redirected, e.g. https://gristlabs.github.io/grist-widget/invoices is redirected to https://gristlabs.github.io/grist-widget/invoices/. On GitHub pages this is actually fine, but when the dev server does the equivalent redirect it also removes query params, potentially causing confusing bugs in local development.
This isn't currently a concern since none of these widgets use the query params provided by Grist such as
accessortimeZone. I mostly just want to highlight this so that future widgets consistently use a redirect-free URL.This can only be merged safely if we can guarantee that changing a URL in the manifest won't clear widget settings in existing documents (via changing the URL of the widget) and I'm not sure if it's worth the effort to ensure that right now.
The trailing
index.htmlin each URL is probably not needed but I wanted to be consistent with other widgets.