fix_pkill #38
fix_pkill #38
Conversation
fix preset JVM options.
| @@ -83,7 +83,7 @@ CP=${CP}":${SCRIPT_DIR}/../libs/*" | |||
| # | |||
| # ADD YOUR/CHANGE ADDITIONAL OPTIONS HERE | |||
| # | |||
| JVM_OPTS="-Xms2g -Xmx2g -server -Djava.net.preferIPv4Stack=true "${JVM_OPTS} | |||
| JVM_OPTS="-Djava.net.preferIPv4Stack=true "${JVM_OPTS} | |||
There was a problem hiding this comment.
Seems this not related to the issue?
There was a problem hiding this comment.
Yes, but this applies to overriding JVM options. They are configured in .properties. Their presence is not justified here.
There was a problem hiding this comment.
Feel free to propose additional PR with this fix.
Let reviewers check one fix per PR.
|
|
||
| else | ||
| `ssh -o PasswordAuthentication=no ${REMOTE_USER}"@"${host_name} pkill -9 -f "Dyardstick.server"` |
There was a problem hiding this comment.
@SviridovMM if you have promlems with JFR then just set duration in profiler parameters (see below) less than benchmarks duration.
-XX:StartFlightRecording=duration=Ns
Changing the signal for the pkill command can cause problems with hung Java processes.
There was a problem hiding this comment.
@isuntsov-gridgain, could you explain why this change may lead to hanging?
No description provided.