Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Member ID support unique to server or driver. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdiyewar
Copy link

@rdiyewar rdiyewar commented Jun 1, 2015

While implementing yardstick support for my product, i wanted to distiguish between servers and wanted to implement one out of many server in a specific way, however i could not find any way to do this.

Thus i added MemberID for each member in yardstick which is unique to Servers (Or Drivers). They can now be distinguish between themselves using this MemberID.

Added print statement in Server Configuring server id= and DriverConfiguring driver id= inside EchoBenchmark example and found following output

$ grep "Configuring server" * -r
logs_servers/0_localhost.log:<16:42:11><yardstick> Configuring server id=0
logs_servers/1_localhost.log:<16:42:21><yardstick> Configuring server id=1

$ grep "Configuring driver" * -r
logs_drivers/164224_0_localhost.log:<16:42:34><yardstick> Configuring driver id=0
logs_drivers/164241_1_localhost.log:<16:42:51><yardstick> Configuring driver id=1

… Drivers) can now be distinguish between themselves using this MemberID.
@ashutakGG
Copy link
Contributor

Hi,

Thank you for your contribution! Looks like it can be useful.

Do you run your servers/drivers on the same or different hosts? If on different then you can use hostname as an id.

We will do more detailed review in a couple days.

@rdiyewar
Copy link
Author

rdiyewar commented Jun 2, 2015

I had ran them on localhost, but my plan are to run actual benchmark on different hosts. Anyways I don't want to use hostname inside code and make it host specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants