Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GG-37923 Add @QuerySqlTable annotation #2976

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

GG-37923 Add @QuerySqlTable annotation #2976

wants to merge 9 commits into from

Conversation

sdarlington
Copy link
Contributor

No description provided.

slukyano
slukyano requested changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@slukyano slukyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few minor suggestions, and let's add a few tests.

modules/core/src/main/java/org/apache/ignite/cache/query/annotations/QuerySqlTable.java Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/ignite/cache/QueryEntity.java Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/ignite/cache/query/annotations/QuerySqlTable.java Show resolved Hide resolved
@sdarlington sdarlington marked this pull request as ready for review December 11, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slukyano slukyano Awaiting requested review from slukyano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdarlington @slukyano