GG-37730 Logging improvements for events of WAL segments deletion #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-chugunov-1985
requested review from
ibessonov and
sashapolo
and removed request for
ibessonov
sashapolo
reviewed
Nov 20, 2023
| @@ -1067,16 +1067,19 @@ private boolean hasIndex(long absIdx) { | |||
|
|
|||
| int deleted = 0; | |||
|
|
|||
| List<String> deletedSegments = new ArrayList<>(); | |||
There was a problem hiding this comment.
I would suggest to use lazy initialization here and in similar places, since this is only for logging
| if (cleanedUpSize > 0) | ||
| deletedRawSegments.add(desc.idx); | ||
|
|
||
| segmentAware.addSize(desc.idx, -cleanedUpSize); |
There was a problem hiding this comment.
should we move this line under the if as well?
...ache/ignite/internal/processors/cache/persistence/db/wal/WalDeletionArchiveAbstractTest.java
Outdated
Show resolved
Hide resolved
| */ | ||
| private Ignite startGrid(Consumer<DataStorageConfiguration> customConfigurator) throws Exception { | ||
| private Ignite startGrid(Consumer<DataStorageConfiguration> customConfigurator, IgniteLogger customLog) throws Exception { |
There was a problem hiding this comment.
Do we use Nullable annotations in GG?
...ache/ignite/internal/processors/cache/persistence/db/wal/WalDeletionArchiveAbstractTest.java
Outdated
Show resolved
Hide resolved
...ache/ignite/internal/processors/cache/persistence/db/wal/WalDeletionArchiveAbstractTest.java
Outdated
Show resolved
Hide resolved
…rs/cache/persistence/db/wal/WalDeletionArchiveAbstractTest.java Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
…rs/cache/persistence/db/wal/WalDeletionArchiveAbstractTest.java Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
…rs/cache/persistence/db/wal/WalDeletionArchiveAbstractTest.java Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
sashapolo
approved these changes
Nov 22, 2023
sergey-chugunov-1985
added a commit
that referenced
this pull request
Nov 23, 2023
…h additional logging (#2963) Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com> Signed-off-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
sergey-chugunov-1985
added a commit
that referenced
this pull request
Nov 24, 2023
…h additional logging (#2963) Co-authored-by: Alexander Polovtcev <alex.polovtcev@gmail.com> Signed-off-by: Alexander Polovtcev <alex.polovtcev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.