[PowerA/Switch] Drastically improve accuracy of the right pad with horrific hacks #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the touchpad implementation has deadzones and is offset by ~15 degrees. I suspect the real problem are the strange
adc_vals_{x,y}assignments insidetrackpadGetLastXY. However; I'm definitely unable to fix those so I instead try to make the touchpad "seem" more accurate by offsetting the values manually afterwards.I don't expect this to be merged
But; putting it as a PR for discoverability since others may want these changes as they do make the touchpad a lot more viable.
As a side note, if you also want to make the right touchpad only act as right joystick when pressed, you can simply wrap the statusReport assignment with
if (getRightTrackpadClickState())