Spelling #306
Open
Spelling #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jsoref
commented
Dec 31, 2023
| The contribution to this project requires setting up a development | ||
| Contribution to this project requires setting up a development |
There was a problem hiding this comment.
This isn't precisely a spelling thing, it's more of a grammar thing... Anyway, The does the wrong thing here.
| Second, fork the following repositories in Github into to your own Github | ||
| Second, fork the following repositories in GitHub into to your own GitHub |
| @@ -82,7 +82,6 @@ qtest: covdir | |||
| @time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileSingleSignOnProvider ./*.go | |||
| @#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileCredentials ./*.go | |||
| @#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileMessaging ./*.go | |||
| @#time richgo test -v -coverprofile=.coverage/coverage.out -run TestParseCaddyfileIdentit* ./*.go | |||
There was a problem hiding this comment.
Line 81 above had nearly identical content and there doesn't seem to be anything that would match this that didn't match that.
Comment on lines
-134
to
+135
| b, err := ioutil.ReadFile(args) | ||
| b, err := os.ReadFile(args) |
There was a problem hiding this comment.
Go made me do it? ioutil.ReadFile is deprecated and apparently it just uses os.ReadFile
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/caddy-security/actions/runs/7372197546/attempts/1#summary-20060295535
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/caddy-security/actions/runs/7372197602/attempts/1#summary-20060295600