Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce vertx http and tcp client factories #296

Merged
merged 2 commits into from Mar 7, 2024

Conversation

ytvnr
Copy link
Member

@ytvnr ytvnr commented Mar 6, 2024

Issue

https://gravitee.atlassian.net/browse/APIM-3799

Description

Introduce VertxHttpClientFactory in a central place so that any project can use it.
In the case of APIM, it will be useful for

  • http-proxy endpoint
  • http health check api service (v4)
  • http dynamic properties service (v4)

Also introduce VertxTcpClientFactory:

  • useful for tcp-proxy endpoint

Gravitee.io Automatic Deployment

馃殌 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

  • use it directly by updating your project with version: 5.9.0-apim-3799-extract-httpclient-factory-SNAPSHOT
  • download it from Artifactory here

@ytvnr ytvnr requested a review from a team as a code owner March 6, 2024 08:36
@ytvnr ytvnr requested a review from a team March 6, 2024 08:36
@ytvnr ytvnr force-pushed the apim-3799-extract-httpclient-factory branch from 9b22a36 to c18ce65 Compare March 6, 2024 08:38
@ytvnr ytvnr force-pushed the apim-3799-extract-httpclient-factory branch 2 times, most recently from 603ea7d to 76e45bc Compare March 6, 2024 09:07
Copy link

@remibaptistegio remibaptistegio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just made a few comments, otherwise lgtm.

@ytvnr ytvnr force-pushed the apim-3799-extract-httpclient-factory branch from 76e45bc to 9ffb54c Compare March 7, 2024 13:47
@ytvnr ytvnr changed the title feat: introduce VertxHttpClientFactory feat: introduce vertx http and tcp client factories Mar 7, 2024
@ytvnr ytvnr force-pushed the apim-3799-extract-httpclient-factory branch from 9ffb54c to ce299db Compare March 7, 2024 13:51
@ytvnr ytvnr force-pushed the apim-3799-extract-httpclient-factory branch from ce299db to a98556f Compare March 7, 2024 14:51
@ytvnr ytvnr merged commit 52f7765 into master Mar 7, 2024
8 checks passed
@ytvnr ytvnr deleted the apim-3799-extract-httpclient-factory branch March 7, 2024 15:01
@graviteeio
Copy link
Contributor

馃帀 This PR is included in version 5.9.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants