New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce vertx http and tcp client factories #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytvnr
force-pushed
the
apim-3799-extract-httpclient-factory
branch
from
March 6, 2024 08:38
9b22a36
to
c18ce65
Compare
jgiovaresco
approved these changes
Mar 6, 2024
...itee-node-vertx/src/main/java/io/gravitee/node/vertx/client/http/VertxHttpClientOptions.java
Show resolved
Hide resolved
...-node-vertx/src/test/java/io/gravitee/node/vertx/client/http/VertxHttpClientFactoryTest.java
Show resolved
Hide resolved
ytvnr
force-pushed
the
apim-3799-extract-httpclient-factory
branch
2 times, most recently
from
March 6, 2024 09:07
603ea7d
to
76e45bc
Compare
remibaptistegio
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just made a few comments, otherwise lgtm.
gravitee-node-vertx/src/main/java/io/gravitee/node/vertx/client/ssl/pkcs12/PKCS12KeyStore.java
Outdated
Show resolved
Hide resolved
...-node-vertx/src/test/java/io/gravitee/node/vertx/client/http/VertxHttpClientFactoryTest.java
Outdated
Show resolved
Hide resolved
...-node-vertx/src/test/java/io/gravitee/node/vertx/client/http/VertxHttpClientFactoryTest.java
Outdated
Show resolved
Hide resolved
ytvnr
force-pushed
the
apim-3799-extract-httpclient-factory
branch
from
March 7, 2024 13:47
76e45bc
to
9ffb54c
Compare
ytvnr
changed the title
feat: introduce VertxHttpClientFactory
feat: introduce vertx http and tcp client factories
Mar 7, 2024
ytvnr
force-pushed
the
apim-3799-extract-httpclient-factory
branch
from
March 7, 2024 13:51
9ffb54c
to
ce299db
Compare
remibaptistegio
approved these changes
Mar 7, 2024
ytvnr
force-pushed
the
apim-3799-extract-httpclient-factory
branch
from
March 7, 2024 14:51
ce299db
to
a98556f
Compare
馃帀 This PR is included in version 5.9.0 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-3799
Description
Introduce
VertxHttpClientFactory
in a central place so that any project can use it.In the case of APIM, it will be useful for
Also introduce
VertxTcpClientFactory
:Gravitee.io Automatic Deployment
馃殌 A prerelease version of this package has been published on Gravitee's private artifactory, you can:
5.9.0-apim-3799-extract-httpclient-factory-SNAPSHOT