Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update bcprov-jdk15on to bcprov-jdk18on #295

Merged
merged 1 commit into from Mar 7, 2024
Merged

fix(deps): update bcprov-jdk15on to bcprov-jdk18on #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions gravitee-node-certificates/pom.xml
View file
Open in desktop
Expand Up @@ -77,12 +77,12 @@
<!-- Bouncy Castle -->
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<artifactId>bcprov-jdk18on</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<artifactId>bcpkix-jdk18on</artifactId>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While doing this task I noticed that this lib bcpkix-jdk15on was also moved to bcpkix-jdk18on so I bumped it up as well. I hope that's fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, It's fine, but you need to create a PR in APIM with 5.8.2-apim-4028-update-to-bcprov-jdk18on-SNAPSHOT version of node and make sure all tests pass. I'm pretty sure it is used in the project (look at gravitee-gateway-test-sdk and integration-tests projects first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pom.xml
gravitee-apim-rest-api/gravitee-apim-rest-api-standalone/gravitee-apim-rest-api-standalone-container/pom.xml
gravitee-apim-rest-api/gravitee-apim-rest-api-idp/gravitee-apim-rest-api-idp-core/pom.xml
gravitee-apim-gateway/gravitee-apim-gateway-security/gravitee-apim-gateway-security-jwt/pom.xml
gravitee-apim-gateway/gravitee-apim-gateway-handlers/gravitee-apim-gateway-handlers-api/pom.xml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those files make ref to BC. Make sure it is up to date.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benoitgravitee. Sure thing, here I created APIM PR with the changes you mentioned:
https://github.com/gravitee-io/gravitee-api-management/pull/6837/files

<scope>test</scope>
</dependency>

Expand Down
4 changes: 2 additions & 2 deletions gravitee-node-kubernetes/pom.xml
View file
Open in desktop
Expand Up @@ -128,12 +128,12 @@
<!-- Bouncy Castle -->
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<artifactId>bcprov-jdk18on</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<artifactId>bcpkix-jdk18on</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
4 changes: 2 additions & 2 deletions gravitee-node-license/pom.xml
View file
Open in desktop
Expand Up @@ -96,12 +96,12 @@
<!-- Bouncy Castle -->
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<artifactId>bcprov-jdk18on</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<artifactId>bcpkix-jdk18on</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
4 changes: 2 additions & 2 deletions gravitee-node-secrets/gravitee-node-secrets-service/pom.xml
View file
Open in desktop
Expand Up @@ -59,13 +59,13 @@
<!-- Bouncy Castle -->
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<artifactId>bcprov-jdk18on</artifactId>
<version>${bouncycastle.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<artifactId>bcpkix-jdk18on</artifactId>
<version>${bouncycastle.version}</version>
<scope>test</scope>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion gravitee-node-vertx/pom.xml
View file
Open in desktop
Expand Up @@ -102,7 +102,7 @@

<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<artifactId>bcpkix-jdk18on</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Expand Up @@ -71,7 +71,7 @@
<!-- WARNING: the next two dependencies versions must be kept in sync regarding vertx-micrometer-metrics -->
<micrometer-registry-prometheus.version>1.10.7</micrometer-registry-prometheus.version>
<LatencyUtils.version>2.0.3</LatencyUtils.version>
<bouncycastle.version>1.70</bouncycastle.version>
<bouncycastle.version>1.77</bouncycastle.version>
<guava.version>32.0.1-jre</guava.version>
<license3j.version>3.2.0</license3j.version>
<maven-assembly-plugin.version>3.3.0</maven-assembly-plugin.version>
Expand Down Expand Up @@ -218,12 +218,12 @@
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<artifactId>bcprov-jdk18on</artifactId>
<version>${bouncycastle.version}</version>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>
<artifactId>bcpkix-jdk18on</artifactId>
<version>${bouncycastle.version}</version>
</dependency>
<dependency>
Expand Down