Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement DiscoverIntegrationAssetUseCase #7075

Merged
merged 7 commits into from Mar 29, 2024

Conversation

jgiovaresco
Copy link
Contributor

@jgiovaresco jgiovaresco commented Mar 28, 2024

Issue

https://gravitee.atlassian.net/browse/APIM-4204

Description

Implement business rules for the Federation Discovery feature. It is currently not "callable" as we don't have any endpoint on the REST API or an actual implementation of IntegrationAgent. However, it should contain everything necessary for the creation of the new type of API

Additional context


馃摎聽聽View the storybook of this branch here

@jgiovaresco jgiovaresco marked this pull request as ready for review March 28, 2024 08:57
@jgiovaresco jgiovaresco requested a review from a team as a code owner March 28, 2024 08:57
@jgiovaresco jgiovaresco force-pushed the apim4204-federated-api branch 4 times, most recently from 9cb1f88 to d6ad22f Compare March 28, 2024 15:24
Copy link
Contributor

@JedrzejJanasiak JedrzejJanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CreateApiDomainService's create method applies a validation automatically.
We will need to use a different validation process for a new type of API
(Federated API).

I didn't want to mix validation of different API types, so I added a
parameter to the create method to provide the validation process as a
lambda function.
Implement business rules for the Federation Discovery feature. It is
currently not "callable" as we don't have any endpoint on the REST API
or an actual implementation of IntegrationAgent. However, it should
contain everything necessary for the creation of the new type of API

https://gravitee.atlassian.net/browse/APIM-4204
The default port 8062 is already be used by Cockpit.
This package contains interfaces of services that can be used in core.
In Hexagonal Architecture, they match to components on the right side.
@jgiovaresco jgiovaresco merged commit d8f7038 into master Mar 29, 2024
38 checks passed
@jgiovaresco jgiovaresco deleted the apim4204-federated-api branch March 29, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants