New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement DiscoverIntegrationAssetUseCase #7075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiovaresco
force-pushed
the
apim4204-federated-api
branch
from
March 28, 2024 08:57
1e7f71e
to
88b5aa1
Compare
jgiovaresco
force-pushed
the
apim4204-federated-api
branch
4 times, most recently
from
March 28, 2024 15:24
9cb1f88
to
d6ad22f
Compare
JedrzejJanasiak
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jgiovaresco
force-pushed
the
apim4204-federated-api
branch
from
March 28, 2024 16:03
d6ad22f
to
c9690d9
Compare
CreateApiDomainService's create method applies a validation automatically. We will need to use a different validation process for a new type of API (Federated API). I didn't want to mix validation of different API types, so I added a parameter to the create method to provide the validation process as a lambda function.
Implement business rules for the Federation Discovery feature. It is currently not "callable" as we don't have any endpoint on the REST API or an actual implementation of IntegrationAgent. However, it should contain everything necessary for the creation of the new type of API https://gravitee.atlassian.net/browse/APIM-4204
The default port 8062 is already be used by Cockpit.
This package contains interfaces of services that can be used in core. In Hexagonal Architecture, they match to components on the right side.
jgiovaresco
force-pushed
the
apim4204-federated-api
branch
from
March 28, 2024 21:24
c9690d9
to
ab0a93a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-4204
Description
Implement business rules for the Federation Discovery feature. It is currently not "callable" as we don't have any endpoint on the REST API or an actual implementation of IntegrationAgent. However, it should contain everything necessary for the creation of the new type of API
Additional context
馃摎聽聽View the storybook of this branch here