fix: add secret converter for all IdP plugin #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgravitee
force-pushed
the
fix-secret-convertion-idp-manager
branch
2 times, most recently
from
05fba13
to
ec0763c
Compare
benoitgravitee
force-pushed
the
fix-secret-convertion-idp-manager
branch
from
ec0763c
to
763324a
Compare
jgiovaresco
approved these changes
Mar 19, 2024
jhaeyaert
reviewed
Mar 19, 2024
...ore/src/main/java/io/gravitee/rest/api/idp/core/plugin/impl/IdentityProviderManagerImpl.java
Outdated
Show resolved
Hide resolved
benoitgravitee
force-pushed
the
fix-secret-convertion-idp-manager
branch
from
f93c841
to
4a0c50f
Compare
jhaeyaert
approved these changes
Mar 21, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
No converter found capable of converting from type [io.gravitee.node.api.secrets.model.Secret] to type [java.lang.String]when setting up in memory users
Fix
Add converter where they lacked