Simplify core elements initialization with Spring #6882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiovaresco
force-pushed
the
simplify-domain-service-registration-run-e2e
branch
2 times, most recently
from
ccd0eaa
to
2cd143b
Compare
ytvnr
reviewed
Mar 11, 2024
...apim-rest-api-service/src/main/java/io/gravitee/apim/core/api/use_case/ImportCRDUseCase.java
Outdated
Show resolved
Hide resolved
jgiovaresco
force-pushed
the
simplify-domain-service-registration-run-e2e
branch
from
2cd143b
to
61e0688
Compare
Passing run #855 ↗︎
Details:
Review all test suite changes for PR #6882 ↗︎ |
|||||||||||||||
jgiovaresco
force-pushed
the
simplify-domain-service-registration-run-e2e
branch
from
61e0688
to
9ba8142
Compare
jourdiw
approved these changes
Mar 12, 2024
...pim-rest-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/core/UseCase.java
Outdated
Show resolved
Hide resolved
ytvnr
approved these changes
Mar 13, 2024
Also declare alternative in InMemoryConfiguration
jgiovaresco
force-pushed
the
simplify-domain-service-registration-run-e2e
branch
from
9ba8142
to
f2a35b8
Compare
This will allow to configure Spring component scan to init use cases.
This will allow to configure Spring component scan to init all services.
jgiovaresco
force-pushed
the
simplify-domain-service-registration-run-e2e
branch
from
f2a35b8
to
56dd256
Compare
jgiovaresco
force-pushed
the
simplify-domain-service-registration-run-e2e
branch
from
56dd256
to
4a9bf57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR tries to simplify the spring configuration related to core elements.
As we don't want to reference Spring in the Core package, declaring beans was cumbersome because we had to add them in a Configuration file manually.
This PR suggests 2 remediations based on
@ComponentScanannotation:domain_service...@UseCaseand@DomainService. Then, we can configure Component Scan to search for that annotation to discover beans.I like the second approach for 2 reasons:
Additional context
📚 View the storybook of this branch here