test: define a InMemoryConfiguration that can be shared #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each rest module was defining its own InMemoryConfiguration. It was a pain when we introduce new InMemory implementation because we had to add the declaration in 3 files. Now there is only one InMemoryConfiguration located next to in memory alternatives. This configuration is packaged in test artifact and can be referenced in Spring configuration in each rest module.
jgiovaresco
force-pushed
the
simply-spring-init-in-test
branch
from
c5e2678
to
f63eed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each rest module was defining its own InMemoryConfiguration. It was a pain to introduce new InMemory implementation because we had to add the declaration in 3 files.
Now, there is only one InMemoryConfiguration located next to in-memory alternatives. This configuration is packaged in test artifact and can be referenced in Spring configuration in each rest module.
Additional context
馃摎聽聽View the storybook of this branch here