Introduction of CreateV4ApiUseCase #6827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #810 鈫楋笌
Details:
Review all test suite changes for PR #6827 鈫楋笌 |
|||||||||||||||
jgiovaresco
force-pushed
the
apim3959-create-api-usecase-run-e2e
branch
3 times, most recently
from
9c41e88
to
5384a07
Compare
jourdiw
reviewed
Mar 6, 2024
...nagement-v2-rest/src/main/java/io/gravitee/rest/api/management/v2/rest/mapper/ApiMapper.java
Show resolved
Hide resolved
.../gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/infra/adapter/ApiAdapter.java
Outdated
Show resolved
Hide resolved
jgiovaresco
force-pushed
the
apim3959-create-api-usecase-run-e2e
branch
from
5384a07
to
7fe13e7
Compare
jourdiw
approved these changes
Mar 6, 2024
ytvnr
reviewed
Mar 7, 2024
...api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/core/api/model/NewApi.java
Show resolved
Hide resolved
...st-api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/core/api/model/Api.java
Outdated
Show resolved
Hide resolved
...api/gravitee-apim-rest-api-service/src/main/java/io/gravitee/apim/core/api/model/NewApi.java
Outdated
Show resolved
Hide resolved
...im-rest-api-service/src/main/java/io/gravitee/apim/core/api/use_case/CreateV4ApiUseCase.java
Show resolved
Hide resolved
...i-service/src/main/java/io/gravitee/apim/core/api/domain_service/CreateApiDomainService.java
Show resolved
Hide resolved
...i-service/src/main/java/io/gravitee/apim/core/api/domain_service/CreateApiDomainService.java
Outdated
Show resolved
Hide resolved
...i-service/src/main/java/io/gravitee/apim/core/api/domain_service/CreateApiDomainService.java
Outdated
Show resolved
Hide resolved
ytvnr
approved these changes
Mar 7, 2024
jourdiw
pushed a commit
that referenced
this pull request
Mar 11, 2024
Follow the work initiated in #6659 It introduces a new use case used by mAPI v2 when creating a new V4 API. The ImportCRDUseCase and the Cockpit handler creating V4 API have also been updated to use the new Domain Service introduced earlier. All of this work allows us to remove the create method we have in ApiService 馃帀 https://gravitee.atlassian.net/browse/APIM-3959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-3959
Description
Follow the work initiated in #6659
It introduces a new use case used by mAPI v2 when creating a new V4 API.
The ImportCRDUseCase and the Cockpit handler creating V4 API have also been updated to use the new Domain Service introduced earlier.
All of this work allows us to remove the
createmethod we have in ApiService 馃帀Additional context
馃摎聽聽View the storybook of this branch here