Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING.md and PR template to include PR title specifications #861

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

bdpedigo
Copy link
Collaborator

@bdpedigo bdpedigo commented Oct 13, 2021

  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
    • Is the change to the API backwards compatible?
  • Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Adds some example PR titles to the contributing document. Also a reminder in the PR checklist

See #850 (comment)

@bdpedigo bdpedigo changed the title Updated CONTRIBUTING.md to include PR title specifications Updated CONTRIBUTING.md and PR template to include PR title specifications Oct 13, 2021
Copy link
Contributor

@daxpryce daxpryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's beautiful

@daxpryce daxpryce merged commit 12bfee5 into dev Oct 15, 2021
@daxpryce daxpryce deleted the add-pr-title-examples branch October 15, 2021 17:57
daxpryce pushed a commit that referenced this pull request Nov 5, 2021
…tions (#861)

* Update CONTRIBUTING.md

* Update PULL_REQUEST_TEMPLATE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants