Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in check_dirloop, check_r and check_rel_sbm #1012

Commits on Sep 16, 2022

  1. Merge pull request graspologic-org#988 from microsoft/main

    main into dev pre 2.0.1
    daxpryce committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    d992701 View commit details
    Browse the repository at this point in the history
  2. Fix seaborn syntax

    bdpedigo authored and daxpryce committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    dc0a566 View commit details
    Browse the repository at this point in the history
  3. Increment bugfix version

    bdpedigo authored and daxpryce committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    899a470 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Exclude 3.6.1

    I added to line 35. I assumed the asterisk on 3.3 meant all versions of 3.3 ex (3.3.1, 3.3.2) are all excluded from the matplotlib. 
    
    Is this correct?
    hugwuoke authored and daxpryce committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    64d2f7e View commit details
    Browse the repository at this point in the history
  2. Update setup.cfg

    hugwuoke authored and daxpryce committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    357c933 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Update README.md

    Removed outdated Zenodo DOI from README.md
    ktwillcode authored and bdpedigo committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    d2bd257 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Fixed graph matching with similarity matrix of unequal dimensions (gr…

    …aspologic-org#1002)
    
    * Fix seaborn syntax
    
    * fixed padding of a similarity amtrix for graph matching
    
    * fixing mypy complaint from _adj_pad
    
    * use naive padding for similarity
    
    * add a test
    
    * Revert "Fix seaborn syntax"
    
    This reverts commit fd38e05.
    
    * try to fix ipython error in doc generation
    
    * just make sure the original S had the right shape
    
    * run black
    
    * fix tests
    
    Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
    dokato and bdpedigo committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    194678d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Edited contributing guidelines (graspologic-org#1000)

    * Editing contributing guidelines 
    
    My edits were based on my experience with getting set up on GitHub. I added some minor changes of things I wish I had read while I was trying to set up my account.
    
    * fix typo
    
    Co-authored-by: Benjamin Pedigo <benjamindpedigo@gmail.com>
    hugwuoke and bdpedigo committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5bc51bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a2bdf9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a410de9 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Optimize check_dirloop, check_r and check_rel_sbm

    check_dirloop: You could try replacing the isinstance checks with simple type checks, since bool is a subclass of int and isinstance will also return True if the argument is an int.
    
    check_r: You could try replacing the np.issubdtype check with a simple type check, since float is a subclass of int and np.issubdtype will also return True if the argument is an int.
    
    check_rel_sbm: You could try replacing the nested for loops with a single loop over the flattened array, using the ndarray.flat attribute
    GuilhermeMonteiroPeixoto committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    b6a7cc0 View commit details
    Browse the repository at this point in the history