Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode values larger than maxStorableValue as infinity #2990

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

otbutz
Copy link
Contributor

@otbutz otbutz commented Apr 25, 2024

  • TODO: is this problematic for turn costs?

@karussell
Copy link
Member

The current approach is more conservative. What would be the advantage of this proposal?

@otbutz
Copy link
Contributor Author

otbutz commented Apr 29, 2024

It's only conservative as long as the maximum value we allow to be encoded exceeds what's relevant for routing decisions. #2987 is an example where this strategy introduces artificial weight limits that are far lower than what is actually tagged in OSM, while the encoded value is still in the range of values relevant to truck routing. Searching for a route with a 26t truck in my case.

Ideally, the EV should be able to cover all "sane" values (see #2989), so that we can ignore values that are either tagging errors like kilograms instead of tonnes, or are far too high for our intended use case.

For example, this way has a maximum weight limit of 120t. In practice, this is so high that it's irrelevant for any normal vehicle. But by limiting it to the maximum storage value of the EV, we create an artificial limit within the range of values relevant to large trucks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants