New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure turn cost calculation #2957
Open
karussell
wants to merge
32
commits into
master
Choose a base branch
from
turn_costs_calc
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support indicated that only a single coordinate is affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #1590.
Use cases:
urban_density
and avoiding CITY.Configuration to avoid zig zag routes for bike:
The implementation fills an
orientation
encoded value where the forward value stores the orientation of the end segment of the edge and the backward value stores the orientation of the start segment of the edge. With that all turn angles can be calculated. Of course sometimes a "left turn" cannot be detected from the angle alone and topology must be considered but for now this orientation approach works good enough (and the topology approach did not work that well alone when I tried it before).A more sophisticated implementation could also use different turn costs depending on the
country
orroad_class
but this and a request-based customization of the turn costs (moving it into the custom_model) should not be part of this PR.