Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Draw real geometry of public transit line #2912

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

InterStella0
Copy link

@InterStella0 InterStella0 commented Dec 4, 2023

This PR attempted to implement #1743. The routes that are given by shapes.txt can be inferred even when you don't have shape_dist_traveled via haversine formula or point from line formula.

Sample Output:

image

Thoughts & Problems

  1. Once I've generated the polyline, should it be set onto PtLeg.geometry or a new attribute?
    • I replaced geometry with a multi line string instead
  2. There are times when the routes completely disappear, I assume this is due to routes missing/unmatched, should this be replaced with a single line from/to stops?
  3. Sometimes the path of point A to point B is a bit far from the closest stop, thus creating an "incomplete" polyline, I guess a way to fix this is to artificially create a point closest to stop relative to the direction of A to B.
  • Example of incomplete polyline:
    image

@InterStella0 InterStella0 marked this pull request as draft December 5, 2023 01:07
@InterStella0 InterStella0 changed the title [WIP] Display route for public transport [WIP] Draw real geometry of public transit line Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant