PT-Isochrones with different access-egress modes. #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegeus
changed the title
idegeus
changed the title
michaz
approved these changes
Sep 28, 2023
| DefaultSnapFilter egressSnapFilter = new DefaultSnapFilter(egressWeighting, encodingManager.getBooleanEncodedValue(Subnetwork.key(egressProfile))); | ||
| PtLocationSnapper.Result snapResult = new PtLocationSnapper(baseGraph, locationIndex, gtfsStorage).snapAll(Arrays.asList(location), Arrays.asList(accessSnapFilter, egressSnapFilter)); | ||
|
|
||
| // TODO: Should also incorporate egressWeighting in some way? Maybe? |
There was a problem hiding this comment.
Ah. The issue is that when we exit a station while expanding our circle, we don't know yet if we are going to take another transit leg, or we are already on our egress leg. The router class doesn't support creating labels for both at once.
I think what you chose to do is fine -- only consider one street mode, and call it access or egress depending on the "direction". It does mean that when we say "car", we will take our transfers by "car" as well, so we basically take our car on the bus.
To be resolved another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #2856