This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Fix code style and static analysis warnings #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ramunasd , I think you can remove the support for 5.6 in the travis builds in this PR, that should make the tests pass. |
ramunasd
force-pushed
the
fix_code_style
branch
from
db05719
to
c7bdef1
Compare
|
IMHO support for 5.6 should be dropped in next major version. Let's leave it now. |
|
Hi @ikwattro this one is ready to merge, just reminder :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspection is done using phpstan and phpstorm inspector.