Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when changing the style of misspelt words #1718

Open
wants to merge 1 commit into
base: maintenance/gramps52
Choose a base branch
from

Conversation

Nick-Hall
Copy link
Member

In the note editor, changing the style of text failing the spell check caused an error. The style tag used by the spell checker to indicate spelling errors has no tag name.

Fixes #13282.

In the note editor, changing the style of text failing the spell
check caused an error.  The style tag used by the spell checker
to indicate spelling errors has no tag name.

Fixes #13282.
@Nick-Hall Nick-Hall added the bug label May 4, 2024
@emyoulation
Copy link
Contributor

emyoulation commented May 4, 2024

Do I need to do anything special to test this patch with the Undo patch done for the rollover of URLs in Notes?

@Nick-Hall
Copy link
Member Author

This is a simple one line fix and is unrelated to any other fix.

@emyoulation
Copy link
Contributor

OK. But I'll apply the patch in #1710 and see if the Note Editor Undo button starts working with the Spell Checker.

Have to set up the Windows box again. This Fedora argues any time I try to patch the application.

@emyoulation
Copy link
Contributor

Thanks for the quick fix to styling with Spellcheck!

The Undo issue is still a (less critical) problem. Will file on PR1710 since it is more closely related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants