Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional img_dpi parameter to add_media in libcairodoc.py #1183

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mattkmmr
Copy link
Member

This optional parameter allows adding images with a different DPI resolutions. This is needed to fix issue #11492 that media included in PDF documents has a low quality and is blurred.
Continues #1007

Add optional img_dpi parameter to add_media in libcairodoc.py
@Nick-Hall
Copy link
Member

When the add_media method is called we don't know what resolution is required for the photos. The same report could be used to generate a high quality print version or a low file size version to email someone.

The photo resolution should probably be an extra report option instead.

@Mattkmmr Mattkmmr marked this pull request as draft August 27, 2021 13:15
@lordemannd
Copy link
Contributor

lordemannd commented Feb 15, 2022

@Mattkmmr you marked this as a draft change, do you mean it needs more work or is it ready to be included? (BTW: I have been using this change (or previous #1007) along with addon # 285, since Jan 26, 2020 without issues)

@lordemannd
Copy link
Contributor

any chance of getting this into 5.1.6 and/or 5.2?

@Mattkmmr
Copy link
Member Author

@lordemannd I changed this PR to draft, because I only implemented the change for libcairodoc and textdoc. It works well for them, but the other document generation files also need an update before this PR can be added. I'll to update the rest this weekend.

@emyoulation
Copy link
Contributor

@Mattkmmr Matt, is this still a 'live' issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants