[LibOS] Do not reuse chroot_unlink() in shm filesystem
#1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a bad smell to reuse functions intended for another subsystem. Also, a future commit will modify `chroot_unlink()` such that `shm` FS won't be able to reuse it. Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
dimakuv
commented
Mar 14, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
libos/src/fs/chroot/encrypted.c line 281 at r1 (raw file):
/* NOTE: this function is different from generic `chroot_unlink` only to add PAL_OPTION_PASSTHROUGH. * Once that option is removed, we can safely go back to using `chroot_unlink`. */
In #1812, it will differ in other ways too, so I just decided to remove the commit here (even though it's a bit unrelated)
2 tasks
kailun-qin
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from different teams (1 more required, approved so far: Intel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
It is a bad smell to reuse functions intended for another subsystem. Also, a future commit will modify
chroot_unlink()such thatshmFS won't be able to reuse it.Extracted from #1812.
How to test this PR?
N/A.
This change is