Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ProgressCallback #619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ProgressCallback #619

wants to merge 1 commit into from

Conversation

yelliver
Copy link

@yelliver yelliver commented Dec 26, 2023

Wrong params order of ProgressCallback

  • The correct order should be downloaded, total, not total, downloaded.

Wrong calling time of progressCallback when downloading

  • The actual number of downloaded bytes should be updated first before the results are reflected in the progressCallback, or else the progress will never reach 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant