Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TraceQL] quantile_over_time 2 of 2 - engine #3633

Merged
merged 18 commits into from
May 7, 2024
Merged

[TraceQL] quantile_over_time 2 of 2 - engine #3633

merged 18 commits into from
May 7, 2024
+847 −140

Commits on Apr 24, 2024

  1. Add lang/parser support for quantile_over_time, fix missing stringify… 

    … of metrics and hints
    @mdisibio
    mdisibio committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    50a6984 View commit details
    Browse the repository at this point in the history

  2. First working draft of quantile_over_time implementation

    @mdisibio
    mdisibio committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7307d4c View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Validate the query in the frontend

    @mdisibio
    mdisibio committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    589d83f View commit details
    Browse the repository at this point in the history

  2. Histogram accumulate jobs by bucket as they come in instead of at the… 

    … end. Refactor label handling to be shared. Validate quantiles, support quantile_over_time by any integer attribute
    @mdisibio
    mdisibio committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6abee43 View commit details
    Browse the repository at this point in the history

  3. Fix language definition to allow both floats or ints for quantiles

    @mdisibio
    mdisibio committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    923d7d8 View commit details
    Browse the repository at this point in the history

  4. Remove layer of proto->seriesset conversion. Fix roundtrip of __bucke… 

    …t label
    @mdisibio
    mdisibio committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2ccc75f View commit details
    Browse the repository at this point in the history

  5. Rename to SimpleAdditionCombiner, slight interval calc cleanup

    @mdisibio
    mdisibio committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e320bbb View commit details
    Browse the repository at this point in the history

  6. Fix p0 returning 1 instead of minimum value, comments cleanup

    @mdisibio
    mdisibio committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b845743 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Rename frontend param and fix handling of ints

    @mdisibio
    mdisibio committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ee0e5bc View commit details
    Browse the repository at this point in the history

  2. Fix pre-existing bug in metrics optimization when asserting multiple … 

    …conditions on the same attribute
    @mdisibio
    mdisibio committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4c1db95 View commit details
    Browse the repository at this point in the history

  3. Fix to support 3 flavors of the metrics pipeline: query-frontend, acr… 

    …oss blocks, and across generators. Error handling, move code around
    @mdisibio
    mdisibio committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    656f525 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'main' into quantile-engine

    @mdisibio
    mdisibio committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    81deb1b View commit details
    Browse the repository at this point in the history

  2. Update query_range frontend test for new behavior

    @mdisibio
    mdisibio committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cb31ed0 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Consolidate histogram code between traceql and traceqlmetrics. quanti… 

    …le_over_time test, code cleanup
    @mdisibio
    mdisibio committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b49d994 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. lint

    @mdisibio
    mdisibio committed May 2, 2024
    Configuration menu
    Copy the full SHA
    05c3af4 View commit details
    Browse the repository at this point in the history

  2. changelog

    @mdisibio
    mdisibio committed May 2, 2024
    Configuration menu
    Copy the full SHA
    dbe0a18 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Redo histograms to set __bucket label to the actual value instead of … 

    …log2, for several reasons: support non-log2 or native histogram buckets in the future, and where queriers on different versions may have different buckets during rollout
    @mdisibio
    mdisibio committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5c79dc2 View commit details
    Browse the repository at this point in the history

  2. Revert all changes to traceqlmetrics package, was getting too noisy

    @mdisibio
    mdisibio committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3c8507f View commit details
    Browse the repository at this point in the history