Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: attempt bufbuild conversion #3619

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Apr 26, 2024

What this PR does:

Which issue(s) this PR fixes:
Fixes #

TODO

  • tempopb.PreallocBytes needs handling. This was dropped with gogoproto, but I don't see an alternative solution. Needs research.
  • MarshalToSizedBuffer is not handled, I'm not clear on the intent
  • In order to fully test, I believ dskit also needs updating? Unsure how pyroscope worked around this, to investigate.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant