Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop counting client cancels as errors for the SLO #3591

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mapno
Copy link
Member

@mapno mapno commented Apr 19, 2024

What this PR does:

Makes context.Cancel errors count as successes for the SLO.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno marked this pull request as ready for review April 22, 2024 10:03
@mapno mapno added type/bug Something isn't working monitoring/alerts labels Apr 22, 2024
@joe-elliott
Copy link
Member

I don't believe there's a way to know that a context.Canceled error is from the client. If we cancel context in the pipeline and let that error bubble up it would look the same here. I'm not opposed to this, but I think we should throw in some tests to feel confident we don't ever bubble context canceled up here?

in the near-ish future we should move SLO calculations out a layer in cloud to avoid issues like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring/alerts type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants