[DOC] clarify steps in local docker example #3589
Conversation
Two things: mention needing to docker login to the github registry. When I tried this example, I got permission denied until I did this. Mention a debugging step about write permissions on the tempo-data folder. When I followed this guide, I ran into the error I describe here. Hopefully these two clarifications will help out the next person.
dprime
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
|
|
dprime
changed the title
| @@ -2,7 +2,12 @@ | |||
| In this example all data is stored locally in the `tempo-data` folder. Local storage is fine for experimenting with Tempo | |||
| or when using the single binary, but does not work in a distributed/microservices scenario. | |||
|
|
|||
| 1. First start up the local stack. | |||
| Before starting, login to ghcr so you can access the images, using something like: | |||
There was a problem hiding this comment.
do you really need to be logged in to pull from ghcr.io? I don't think I'm logged in and I can pull the image without issue.
Using this stackoverflow answer:
> cat ~/.docker/config.json
{
"auths": {
"https://index.docker.io/v1/": {}
},
...
I don't seem to have an entry for ghcr.io
There was a problem hiding this comment.
You're right. I've just run this on another machine and it works. Do you think it's worth leaving in the permissions change, or just bin the whole PR ?
There was a problem hiding this comment.
I think you have some good updates in the doc itself. You've added some clarifications that help people troubleshoot. If these updates aren't specifically needed, you can keep the section and label it as a "If you want to log in to GHCR" section.
What would you like to do?
What this PR does:
Two things:
Mention needing to docker login to the github registry. When I tried this example, I got permission denied until I did this.
Mention a debugging step about write permissions on the tempo-data folder. When I followed this guide, I ran into the error I describe here. Hopefully these two clarifications will help out the next person.
Which issue(s) this PR fixes:
No issue fixed.