add frontend guidelines #4344
Merged
add frontend guidelines #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brojd
added
pr:no public docs
joeyorlando
approved these changes
May 14, 2024
|
|
||
| - PR can be merged when the following conditions are met: | ||
| pipeline succeeded without bypassing checks | ||
| ere is at least 1 approval from the frontend team and no opened remarks from reviewers other than the approver |
There was a problem hiding this comment.
Suggested change
| ere is at least 1 approval from the frontend team and no opened remarks from reviewers other than the approver | |
| there is at least 1 approval from the frontend team and no opened remarks from reviewers other than the approver |
| - PR can be merged when the following conditions are met: | ||
| pipeline succeeded without bypassing checks | ||
| ere is at least 1 approval from the frontend team and no opened remarks from reviewers other than the approver | ||
| l comments are replied, answered, addressed or discussed separately |
There was a problem hiding this comment.
Suggested change
| l comments are replied, answered, addressed or discussed separately | |
| l comments are replied, answered, addressed or discussed separately |
the "l" here ☝️ is a typo maybe?
| l comments are replied, answered, addressed or discussed separately | ||
| make use of builtin GH PR reviews | ||
| nor comments that don’t need to be addressed right away and are not a blocker for a merge are marked with “Minor: “ prefix | ||
| nless there is some important hotfix to make and no frontend mates are available* |
There was a problem hiding this comment.
Suggested change
| nless there is some important hotfix to make and no frontend mates are available* | |
| unless there is some important hotfix to make and no frontend mates are available* |
Comment on lines
53
to
59
| - For example: | ||
| ithGlobalNotification to set successful / failing notification based on MobX action’s result | ||
| utoLoadingState to manage loading statuses of async actions | ||
| eIsLoading to consume loading state | ||
| eDrawer to manage drawers | ||
| eConfirmModal to manage confirm modal | ||
| obal helpers |
There was a problem hiding this comment.
seems odd here, looks like the first letter of every line got cut off?
There was a problem hiding this comment.
It was broken by copy pasting from markdown previewer tool, I fixed all the places now, thanks
…call into brojd/add_frontend_guidelines
|
@joeyorlando I moved it to /dev folder |
joeyorlando
approved these changes
May 15, 2024
teodosii
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add frontend guidelines as md file
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.