Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PUT/PATCH alert group internal API endpoints #4174

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Apr 5, 2024

What this PR does

  • Add PUT/PATCH alert group internal API endpoints. Will be consumed by the Grafana Incident API to update grafana_incident_id.
    • TODO: figure out how we will handle authnz here (we're currently talking with Identity Access team to possibly use the Cloud Auth API)
  • Update the grafana_incident_id column to be a JSON column (so that we can support storing >= 1 Incident ID for a given alert group)
  • Allow filtering alert groups by grafana_incident_id
  • Update AlertGroup.declare_incident_link to include ID

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@joeyorlando joeyorlando added pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes labels Apr 5, 2024
@joeyorlando joeyorlando self-assigned this Apr 5, 2024
@joeyorlando joeyorlando requested review from a team as code owners April 5, 2024 20:40
… of github.com:grafana/oncall into jorlando/add-alert-group-update-internal-api-endpoints
@joeyorlando joeyorlando marked this pull request as draft April 9, 2024 13:53
@joeyorlando joeyorlando requested a review from a team April 9, 2024 17:59
Copy link

@robert-northmind robert-northmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
but.. 😄 I am no python or django developer but I think it looks good.
thanks @joeyorlando for driving this.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label May 12, 2024
@joeyorlando joeyorlando removed the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants