-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PUT/PATCH alert group internal API endpoints #4174
base: dev
Are you sure you want to change the base?
add PUT/PATCH alert group internal API endpoints #4174
Conversation
… of github.com:grafana/oncall into jorlando/add-alert-group-update-internal-api-endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
but.. 😄 I am no python or django developer but I think it looks good.
thanks @joeyorlando for driving this.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
What this PR does
grafana_incident_id
.grafana_incident_id
column to be a JSON column (so that we can support storing >= 1 Incident ID for a given alert group)grafana_incident_id
AlertGroup.declare_incident_link
to include IDChecklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.