Add tilt button to run pytest, fix local dev config for pytest, minor improvements to til #3927
Conversation
engine/settings/prod_without_db.py
Outdated
| @@ -47,6 +45,8 @@ def on_uwsgi_worker_exit(): | |||
|
|
|||
| CELERY_TASK_ROUTES = celery_task_routes.CELERY_TASK_ROUTES | |||
|
|
|||
| CELERY_TASK_ROUTES = celery_task_routes.CELERY_TASK_ROUTES | |||
There was a problem hiding this comment.
was this intended? (CELERY_TASK_ROUTES is defined two lines above)
There was a problem hiding this comment.
Thank you for checking, I've messed my previous PR #3926, and this typo happened during conflict resolution
engine/settings/helm.py
Outdated
There was a problem hiding this comment.
why these changes here?
There was a problem hiding this comment.
Thank you for checking, I've messed my previous PR #3926, and this typo happened during conflict resolution
iskhakov
changed the title
| @@ -61,7 +61,7 @@ local_resource( | |||
|
|
|||
| local_resource( | |||
| "e2e-tests", | |||
| labels=["E2eTests"], | |||
| labels=["Tests"], | |||
There was a problem hiding this comment.
Need to check how to pin this section on the top
| set -eu | ||
| # get engine k8s pod name from tilt resource name | ||
| POD_NAME="$(tilt get kubernetesdiscovery "engine" -ojsonpath='{.status.pods[0].name}')" | ||
| kubectl exec "$POD_NAME" -- pytest . |
There was a problem hiding this comment.
| kubectl exec "$POD_NAME" -- pytest . | |
| kubectl exec "$POD_NAME" -- pytest . --ds=settings.ci-test |
I'm wondering if there's a way we could also provide optional arguments to pytest? Similar to how we currently have make test-dev and you can run something like this:
$ make test-dev ARGS="apps/api/tests/test_auth.py"
engine/settings/tilt-dev.py
Outdated
There was a problem hiding this comment.
why a separate settings file for tilt?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
pr:stale
github-actions
bot
removed
the
pr:stale
What this PR does
Fixes for https://github.com/grafana/oncall-private/issues/2423
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)