XyChart: Support adding calcs to legend #87155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adela-almasan
added
type/bug
no-changelog
adela-almasan
requested review from
leeoniya and
drew08t
and removed request for
a team
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
baldm0mma
reviewed
May 1, 2024
| @@ -68,17 +78,82 @@ export const XYChartPanel2 = (props: Props2) => { | |||
| getItemKey: () => `${idx}-${s.name.value}`, | |||
| fieldName: yField.state?.displayName ?? yField.name, | |||
| disabled: yField.state?.hideFrom?.viz ?? false, | |||
| getDisplayValues: () => { | |||
There was a problem hiding this comment.
Is this function different than the one used in PlotLegend?
There was a problem hiding this comment.
Or in the original XYChart? Maybe we can DRY it out if it is?
There was a problem hiding this comment.
Pushed a quick update. The plan was to extract it to a separate component, but not today apparently 😅
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-87155-to-v11.0.x origin/v11.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8a96fcedb2f29f60d9a1fffeb0828e38a9cd4f4aWhen the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-87155-to-v11.0.x
# Create the PR body template
PR_BODY=$(gh pr view 87155 --json body --template 'Backport 8a96fcedb2f29f60d9a1fffeb0828e38a9cd4f4a from #87155{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[v11.0.x] XyChart: Fix legend" --body-file - --label "type/bug" --label "area/frontend" --label "area/panel/xychart" --label "no-changelog" --label "backport" --base v11.0.x --milestone 11.0.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-87155-to-v11.0.x
# Create a pull request where the `base` branch is `v11.0.x` and the `compare`/`head` branch is `backport-87155-to-v11.0.x`.
# Remove the local backport branch
git switch main
git branch -D backport-87155-to-v11.0.x |
grafana-delivery-bot
bot
added
the
backport-failed
adela-almasan
changed the title
adela-almasan
changed the title
adela-almasan
added
no-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85034
Please check that: