Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Only show Starred as parent breadcrumb for starred dashboards #87145

Merged
merged 1 commit into from May 1, 2024
Merged

Dashboard: Only show Starred as parent breadcrumb for starred dashboards #87145

merged 1 commit into from May 1, 2024

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

before after
image image

Why do we need this feature?

  • so breadcrumbs appear correctly for starred dashboards in folders

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added type/bug no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 30, 2024
@ashharrison90 ashharrison90 added this to the 11.1.x milestone Apr 30, 2024
@ashharrison90 ashharrison90 self-assigned this Apr 30, 2024
@ashharrison90 ashharrison90 requested a review from a team as a code owner April 30, 2024 15:55
@ashharrison90 ashharrison90 requested review from axelavargas and kaydelaney and removed request for a team April 30, 2024 15:55
axelavargas
axelavargas approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槑 Code looks good to me

tomratcliffe
tomratcliffe approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@tomratcliffe tomratcliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is working, thanks! 馃憤 Is there a clean way to test this within our existing tests at all?

@ashharrison90
Copy link
Contributor Author

Fix is working, thanks! 馃憤 Is there a clean way to test this within our existing tests at all?

yeah not really 馃槄 i might look into creating an e2e utility to verify breadcrumbs at any given point 馃

@ashharrison90 ashharrison90 merged commit f15f21a into main May 1, 2024
29 checks passed
@ashharrison90 ashharrison90 deleted the ash/starred-breadcrumb-fix branch May 1, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelavargas axelavargas axelavargas approved these changes

@tomratcliffe tomratcliffe tomratcliffe approved these changes

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney is a code owner automatically assigned from grafana/dashboards-squad

Assignees

@ashharrison90 ashharrison90

Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/bug
Projects
Grafana Frontend Platform
Status: 馃殌 Done
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashharrison90 @axelavargas @tomratcliffe