Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Scene: Chore - Add missing unit test to PanelDataQueryTab #87139

Merged
merged 4 commits into from May 2, 2024

Conversation

axelavargas
Copy link
Member

Added missing unit test from PR: #86883

@axelavargas axelavargas added type/chore area/frontend no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels Apr 30, 2024
@axelavargas axelavargas self-assigned this Apr 30, 2024
@axelavargas axelavargas requested review from a team as code owners April 30, 2024 14:43
@axelavargas axelavargas requested review from oscarkilhed, mdvictor, joshhunt and Clarity-89 and removed request for a team April 30, 2024 14:43
Copy link
Contributor

Hello @axelavargas!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@axelavargas axelavargas requested review from torkelo and Sergej-Vlasov and removed request for mdvictor, joshhunt and Clarity-89 April 30, 2024 14:44
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 30, 2024
Copy link
Contributor

@Sergej-Vlasov Sergej-Vlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@axelavargas axelavargas merged commit eae1caf into main May 2, 2024
18 checks passed
@axelavargas axelavargas deleted the axelav/add-unit-test branch May 2, 2024 13:54
grafana-delivery-bot bot pushed a commit that referenced this pull request May 2, 2024
…87139)

* Create basic structure PanelDataQueriesTab unit test

* Add more test cases to the PanelDataQueriesTab test

* Update public/app/features/dashboard-scene/panel-edit/VizPanelManager.tsx

(cherry picked from commit eae1caf)
axelavargas added a commit that referenced this pull request May 2, 2024
…QueryTab (#87239)

Dashboard Scene: Chore - Add missing unit test to PanelDataQueryTab (#87139)

* Create basic structure PanelDataQueriesTab unit test

* Add more test cases to the PanelDataQueriesTab test

* Update public/app/features/dashboard-scene/panel-edit/VizPanelManager.tsx

(cherry picked from commit eae1caf)

Co-authored-by: Alexa V <239999+axelavargas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend backport v11.0.x Mark PR for automatic backport to v11.0.x missing-labels no-changelog Skip including change in changelog/release notes type/chore
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants