New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Prevent search from locking the browser #87132
Conversation
this prevents two things 1. very long search strings from exploding the regex permutations 2. a large amount of search terms (whitespace separated) from locking the browser
i would suggest tweaking this further. for the use case linked in the issue, searching for i would recommend detecting such cases and using a different uFuzzy instance configured with the default |
Correct, I had copy pasted it when I ran into some of these locking issues. |
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes LGTM!
this is a bit nicer to read and also makes it more functional
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Approved to back port |
(cherry picked from commit 1d06f33)
(cherry picked from commit 1d06f33)
This PR prevents the following scenarios: