Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: decouple the frontend-part #87131

Merged
merged 1 commit into from May 2, 2024
Merged

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Apr 30, 2024

NOTE: this is the same PR as we did for mysql except i changed the word "mysql" to "postgres" .

fixes #87040

decouples the "frontend part"of the postgres-plugin.

how to test:
just run it, connect to a postgres datasoure, and make sure the query-editor still works.
(for grafana-people, just go to the ephemeral instance below, i configured it with a postgres datasource named psql you can use for testing)

@gabor gabor requested review from a team as code owners April 30, 2024 13:45
@gabor gabor requested review from yesoreyeram, zoltanbedi, gwdawson, mckn and jackw and removed request for a team April 30, 2024 13:45
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 30, 2024
@gabor gabor added the no-changelog Skip including change in changelog/release notes label Apr 30, 2024
@gabor
Copy link
Contributor Author

gabor commented Apr 30, 2024

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes. Follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with gabor/postgres-decouple-frontend oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabor gabor merged commit d7ff321 into main May 2, 2024
29 checks passed
@gabor gabor deleted the gabor/postgres-decouple-frontend branch May 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend datasource/Postgres no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postgres: prepare decoupled frontend
3 participants