Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace static placeholders with translatable ones #87130

Merged
merged 6 commits into from May 1, 2024
Merged

refactor: replace static placeholders with translatable ones #87130

merged 6 commits into from May 1, 2024

Conversation

L-M-K-B
Copy link
Contributor

@L-M-K-B L-M-K-B commented Apr 30, 2024

Which issue(s) does this PR fix?:
Fixes #82091

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@L-M-K-B L-M-K-B added area/internationalization area/frontend/login Issues related to login, changing password, reset password no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 30, 2024
@L-M-K-B L-M-K-B added this to the 11.1.x milestone Apr 30, 2024
@L-M-K-B L-M-K-B requested review from torkelo and a team as code owners April 30, 2024 13:38
@L-M-K-B L-M-K-B requested review from tskarhed and JoaoSilvaGrafana and removed request for a team April 30, 2024 13:38
joshhunt
joshhunt reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to preserve the same functionality as before, but just translate the default values.

So the default.ini entries become empty, and we have a translated default in the LoginForm.

conf/defaults.ini Outdated Show resolved Hide resolved
public/app/core/components/Login/LoginForm.tsx Outdated Show resolved Hide resolved
@L-M-K-B L-M-K-B requested a review from joshhunt April 30, 2024 14:46
joshhunt
joshhunt approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

looks good to me!!!

@L-M-K-B L-M-K-B merged commit f806b97 into main May 1, 2024
15 checks passed
@L-M-K-B L-M-K-B deleted the laura/refactor/replace-login-placeholders branch May 1, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt approved these changes

@torkelo torkelo Awaiting requested review from torkelo torkelo is a code owner

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
area/frontend/login Issues related to login, changing password, reset password area/frontend area/internationalization no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

i18n: Login placeholder markup
2 participants
@L-M-K-B @joshhunt