Tempo: Option to not show variable options in "search" editor #87126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds option
addVariablesToOptions
(defaulttrue
) to Tempo query editor to now show variable options.Why do we need this feature?
Variable options make sense in dashboard context, but not for some app plugins like Application Observability, which use variables for internal reasons that are not meant to be exposed to user.
Who is this feature for?
App plugins that use Tempo query editor variables but do not want to expose the variables to users.
Notes
I considered making the change to limit variable options to only when
app=dashboard
. But not a fan of theapp
concept or making decision for all plugins. I think it's best to let user of the component make the decisionPlease check that: