DashboardScene: Fixes issue referring to library panel in dashboard data source #87125
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
ivanortegaalba,
Sergej-Vlasov,
mdvictor and
dprokop
and removed request for
a team,
ivanortegaalba and
Sergej-Vlasov
torkelo
added
backport v11.0.x
|
Hello @torkelo!
Please, if the current pull request addresses a bug fix, label it with the |
|
This PR must be merged before a backport PR will be created. |
Sergej-Vlasov
approved these changes
Apr 30, 2024
torkelo
added a commit
that referenced
this pull request
May 1, 2024
…ashboard data source (#87173) DashboardScene: Fixes issue referring to library panel in dashboard data source (#87125) * DashboardScene: Fixes issue using a library panel as source for dashboard data source * Added test (cherry picked from commit 4034a26) Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
3 tasks
Sergej-Vlasov
added a commit
that referenced
this pull request
May 2, 2024
…refresh logic (#87232) DashboardScene: adjust lib panel as a dashboard datasource refresh logic (#87120) * activate library viz panel and adjust id extractor * revert parts that are fixed in #87125 * clean up after activation handler (cherry picked from commit afbd02c) Co-authored-by: Sergej-Vlasov <37613182+Sergej-Vlasov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this has worked at all recently (since we moved the key from VizLibraryPanel down to VizPanel). But I could not create a new panel that was using dashboard data source and pick a library panel as the source without seeing "VizPanel key could not be translated to a legacy numeric panel id" errors and the panelId in the targets model ended up being 0.