Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity: Use typed namespace id #87121

Merged
merged 2 commits into from May 2, 2024
Merged

Identity: Use typed namespace id #87121

merged 2 commits into from May 2, 2024

Conversation

kalleep
Copy link
Contributor

@kalleep kalleep commented Apr 30, 2024

What is this feature?
Change so that identity.GetID returns typed version of namespace id instead.

In follow up pr:s we should replace calls to Identity.GetNamespacedID with identity.GetID() and work on the typed structure instead.

Which issue(s) does this PR fix?:
Part of https://github.com/grafana/identity-access-team/issues/652

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kalleep kalleep added the no-changelog Skip including change in changelog/release notes label Apr 30, 2024
@kalleep kalleep added this to the 11.1.x milestone Apr 30, 2024
@kalleep kalleep requested a review from a team as a code owner April 30, 2024 11:14
@kalleep kalleep requested review from a team as code owners April 30, 2024 14:31
@kalleep kalleep requested review from wbrowne, marefr and andresmgot and removed request for a team April 30, 2024 14:31
IevaVasiljeva
IevaVasiljeva approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@IevaVasiljeva IevaVasiljeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalleep kalleep merged commit d8fbbde into main May 2, 2024
12 checks passed
@kalleep kalleep deleted the requester/namespace-id branch May 2, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IevaVasiljeva IevaVasiljeva IevaVasiljeva approved these changes

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@marefr marefr Awaiting requested review from marefr marefr is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees
No one assigned
Labels
area/backend no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalleep @IevaVasiljeva