Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE Sandbox: Fix innerHTML distortion causing issues with DOMPurify inner works #87117

Merged
merged 2 commits into from May 2, 2024
Merged

FE Sandbox: Fix innerHTML distortion causing issues with DOMPurify inner works #87117

merged 2 commits into from May 2, 2024

Conversation

academo
Copy link
Member

@academo academo commented Apr 30, 2024

What is this feature?

Fixes an issue with plugins using DomPurify running inside the frontend sandbox

Why do we need this feature?

Allow plugins using DomPurify to work correctly inside the frontend sandbox

Who is this feature for?

All plugins running inside the frontend sandbox

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone Apr 30, 2024
@academo academo self-assigned this Apr 30, 2024
@academo academo added area/plugins/sandbox area/plugins no-changelog Skip including change in changelog/release notes labels Apr 30, 2024
@academo academo marked this pull request as ready for review April 30, 2024 11:10
@academo academo requested a review from a team as a code owner April 30, 2024 11:10
mckn
mckn approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@academo academo merged commit 9f5ab38 into main May 2, 2024
14 checks passed
@academo academo deleted the academo/fix-sandbox-innerHTML-inspection branch May 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckn mckn mckn approved these changes

@jackw jackw Awaiting requested review from jackw

@leventebalogh leventebalogh Awaiting requested review from leventebalogh

Assignees

@academo academo

Labels
area/frontend area/plugins/sandbox area/plugins no-changelog Skip including change in changelog/release notes
Projects
Plugins Platform
Archived in project
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@academo @mckn