New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GrafanaUI: Add two icons add-user and clip-attach #87112
Conversation
@@ -245,6 +245,8 @@ export const availableIconsIndex = { | |||
'wrap-text': true, | |||
rss: true, | |||
x: true, | |||
'add-user': true, | |||
'clip-attach': true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think paperclip
is a better name, but 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you @joshhunt. Same thought about the "add-user" but it is named from the Unicon official library. 🤷🏻♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey folks 👋🏼 actually I just checked and the names of these icons in Unicon is add-account
and attach
. I think the names we are putting forward are the best ones for discoverability, but feel free if you'd like to rename - no big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly about this (hence why I approved - you can merge whenever you're ready), but either paperclip or attach seem like the best options to me. add-user is fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, i renamed it to be attach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshhunt i'm not one of the authorized users to merge the PR, would you please ?
What is this feature?
Add two icons to the unicons
add-user
andclip-attach
for more : Slack thread
Special notes for your reviewer:
Please check that: