fix ipv6 startup fail #81870

[yincongcyincong]

Which issue(s) does this PR fix?:
When the ipv6 configuration is not enclosed in square brackets，apiserver printed a fatal log and exited.
https://github.com/kubernetes/apiserver/blob/master/pkg/server/config.go#L686
I solve the issue. When the ip is ipv6, it enclose in square brackets.

Fixes #81870 #81870

[CLAassistant]

All committers have signed the CLA.

[RGBCube]

Does it still work when you provide the IP in [] brackets? Wouldn't want to break peoples setups.

[yincongcyincong]

Does it still work when you provide the IP in [] brackets? Wouldn't want to break peoples setups.

the IP in [] brackets don't work, apiserver just get ":3000", don't have IP. but the grafana server can startup normally

[RGBCube]

I think it should be backwards compatible as a few people might already specify ip addresses with brackets.

[DanCech]

There are a few different concerns here, firstly with the current code an ipv6 address wrapped in square brackets will fail because net.ParseIP will fail and return nil in that case, so we can at least exclude that possibility.

The first thing we should likely do is to correctly handle an error parsing the provided address, but to fix that we'll need to update the applyGrafanaConfig function so it can return an error. With that change, if net.ParseIP returns nil we can return an error.

Once we have a valid IP, we can use netip.AddrFromSlice to get a valid Addr from our IP (and handle any errors), then pass that to netip.AddrPortFrom (together with the port) and finally use MarshalText on the returned AddrPort to generate the host string with ipv6 addresses properly wrapped in square brackets (again checking that the returned string is not empty and returning an error).

[yincongcyincong]

There are a few different concerns here, firstly with the current code an ipv6 address wrapped in square brackets will fail because net.ParseIP will fail and return nil in that case, so we can at least exclude that possibility.

The first thing we should likely do is to correctly handle an error parsing the provided address, but to fix that we'll need to update the applyGrafanaConfig function so it can return an error. With that change, if net.ParseIP returns nil we can return an error.

Once we have a valid IP, we can use netip.AddrFromSlice to get a valid Addr from our IP (and handle any errors), then pass that to netip.AddrPortFrom (together with the port) and finally use MarshalText on the returned AddrPort to generate the host string with ipv6 addresses properly wrapped in square brackets (again checking that the returned string is not empty and returning an error).

i think this suggestion is very helpeful, i will update my code.

[yincongcyincong]

I think it should be backwards compatible as a few people might already specify ip addresses with brackets.

new pr is compatible

[grafana-delivery-bot]

Hello @toddtreece!
Backport pull requests need to be either:

• Pull requests which address bugs,
• Urgent fixes which need product approval, in order to get merged,
• Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

[grafana-delivery-bot]

This PR must be merged before a backport PR will be created.

[DanCech]

LGTM

[DanCech]

@yincongcyincong it looks like your earlier commits have an email address that doesn't match your github account, which is causing the CLA bot to reject the PR. I think you can fix that by adding your baidu email address to your github profile here.

[yincongcyincong]

@yincongcyincong it looks like your earlier commits have an email address that doesn't match your github account, which is causing the CLA bot to reject the PR. I think you can fix that by adding your baidu email address to your github profile here.

thanks, bro. i have added my baidu email.